Conversation
tests/test_burger.py
Outdated
Comment on lines
62
to
63
| mock_bun.get_name.return_value = "black bun" | ||
| mock_bun.get_price.return_value = 100 |
There was a problem hiding this comment.
Можно лучше: во всех тестах лучше выносить тестовые данные во внешний модуль (например, data). Это позволит облегчить их поддержку
tests/test_burger.py
Outdated
Comment on lines
61
to
64
| mock_bun = Mock() | ||
| mock_bun.get_name.return_value = "black bun" | ||
| mock_bun.get_price.return_value = 100 | ||
| burger.set_buns(mock_bun) |
There was a problem hiding this comment.
Можно лучше здесь и далее: можно вынести эти вызовы в фикстуру
tests/test_burger.py
Outdated
Comment on lines
76
to
78
| assert "black bun" in receipt | ||
| assert "sauce hot sauce" in receipt # метод делает .lower() | ||
| assert "Price: 300" in receipt # (100*2) + 100 |
There was a problem hiding this comment.
Нужно исправить: проверка через in в данном кейсе не будет надёжной, необходимо проверить полное соответствие
tests/test_burger.py
Outdated
Comment on lines
9
to
32
| def burger(): | ||
| """Фикстура для создания экземпляра Burger.""" | ||
| return Burger() | ||
|
|
||
| @pytest.fixture | ||
| def mock_bun(): | ||
| """ | ||
| Фикстура для создания и настройки мока булки. | ||
| Вся настройка происходит здесь, как и советовал ревьюер. | ||
| """ | ||
| bun = Mock(spec=Bun) | ||
| bun.get_name.return_value = td.BUN_NAME | ||
| bun.get_price.return_value = td.BUN_PRICE | ||
| return bun | ||
|
|
||
| @pytest.fixture | ||
| def mock_ingredients(): | ||
| """ | ||
| Фикстура для создания и настройки моков ингредиентов. | ||
| """ | ||
| ingredient1 = Mock(spec=Ingredient) | ||
| ingredient1.get_type.return_value = td.INGREDIENT_SAUCE_TYPE | ||
| ingredient1.get_name.return_value = td.INGREDIENT_SAUCE_NAME | ||
| ingredient1.get_price.return_value = td.INGREDIENT_SAUCE_PRICE |
There was a problem hiding this comment.
Необходимо исправить: фикстуры стоит вынести в модуль conftest
added 2 commits
January 30, 2026 20:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.